Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalized leapfrog integrator #370

Merged
merged 6 commits into from
Jul 24, 2024
Merged

Generalized leapfrog integrator #370

merged 6 commits into from
Jul 24, 2024

Conversation

xukai92
Copy link
Member

@xukai92 xukai92 commented Jul 11, 2024

No description provided.

@xukai92
Copy link
Member Author

xukai92 commented Jul 11, 2024

tested c99e006 with Geweke on RHMC:
image

yebai
yebai reviewed Jul 11, 2024
View reviewed changes
src/riemannian/integrator.jl Outdated Show resolved Hide resolved
yebai
yebai reviewed Jul 11, 2024
View reviewed changes
src/riemannian/integrator.jl
return return_cache ? (dv, nothing) : dv
end

# TODO(Kai) make sure vectorization works
Copy link
Member

@yebai yebai Jul 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we throw an error when users try vectorisation and tempering with GeneralisedLeapFrog?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i added an error handling for vectorization.
there is no way to do tempering until we define TemperedGeneralizedLeapfrog.

@yebai yebai changed the title Kx/generalized leapfrog Generalized leapfrog integrator Jul 24, 2024
@xukai92 xukai92 merged commit 2b3814c into master Jul 24, 2024
16 checks passed
@xukai92 xukai92 deleted the kx/generalized-lf branch July 24, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yebai yebai yebai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xukai92 @yebai